Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cadeploy.md #424

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atomic-kanta-sasaki
Copy link

fix: command registers the organization CA bootstrap identity rcaadmin with password rcaadminpw with the TLS CA.

Type of change

  • Documentation update

Description

I found and fixed a command that did not work when I was trying the section Register and enroll the organization CA bootstrap identity with the TLS CA.

Additional details

Related issues

@atomic-kanta-sasaki atomic-kanta-sasaki requested review from a team as code owners July 1, 2024 08:09
Copy link
Contributor

@denyeart denyeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually for the 'register' command, the admin client is authenticated using the credentials in the --mspdir flag. There is no need to pass it separately in the -u flag.

For the 'enroll' command, you pass the enroller credentials in the -u flag.

What you've done may work, but to be consistent with the rest of this doc I think we should leave the authentication information out of the register -u flag.

You can look at all the other references of --mspdir in this doc to better understand the documented and intended use.

Perhaps you had --mspdir incorrect which is why it didn't work for you the first time?

@denyeart denyeart self-requested a review July 1, 2024 20:58
atomic-kanta-sasaki and others added 2 commits July 4, 2024 18:11
fix:  command registers the organization CA bootstrap identity rcaadmin with password rcaadminpw with the TLS CA.

Signed-off-by: kanta.sasaki <[email protected]>
Signed-off-by: atomic-kanta-sasaki <[email protected]>
Signed-off-by: atomic-kanta-sasaki <[email protected]>
@atomic-kanta-sasaki
Copy link
Author

@denyeart
I ran it again and found that to be true.
Please confirm that I have corrected the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants